Check if dl library is available and only then link it in for executorch in CMake. (#579) #657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for resplendent-gnome-14e531 canceled.
|
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D50001473 |
tarun292
added a commit
that referenced
this pull request
Oct 7, 2023
…rch in CMake. (#657) Summary: The dl library might not be available on embedded platforms. Before we link it in for executorch core lib we check if it exists for the toolchain we are using and then link it in if it does. Reviewed By: larryliu0820 Differential Revision: D50001473
tarun292
force-pushed
the
export-D50001473
branch
from
fde662d to
acf2601
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50001473 |
tarun292
added a commit
that referenced
this pull request
Oct 7, 2023
…rch in CMake. (#657) Summary: The dl library might not be available on embedded platforms. Before we link it in for executorch core lib we check if it exists for the toolchain we are using and then link it in if it does. Reviewed By: larryliu0820 Differential Revision: D50001473
tarun292
force-pushed
the
export-D50001473
branch
from
acf2601 to
b4e851e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50001473 |
tarun292
added a commit
that referenced
this pull request
Oct 9, 2023
…rch in CMake. (#657) Summary: The dl library might not be available on embedded platforms. Before we link it in for executorch core lib we check if it exists for the toolchain we are using and then link it in if it does. Reviewed By: larryliu0820 Differential Revision: D50001473
tarun292
force-pushed
the
export-D50001473
branch
from
b4e851e to
3b970a3
Compare
…rch in CMake. (#657) Summary: The dl library might not be available on embedded platforms. Before we link it in for executorch core lib we check if it exists for the toolchain we are using and then link it in if it does. Reviewed By: larryliu0820 Differential Revision: D50001473
|
This pull request was exported from Phabricator. Differential Revision: D50001473 |
facebook-github-bot
force-pushed
the
export-D50001473
branch
from
3b970a3 to
0a112ba
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50001473 |
|
This pull request has been merged in 4418dfd. |
Gasoonjia
pushed a commit
that referenced
this pull request
Jul 30, 2024
Change doc to use tokenizer.model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The dl library might not be available on embedded platforms. Before we link it in for executorch core lib we check if it exists for the toolchain we are using and then link it in if it does.
Differential Revision: D50001473