Skip to content

Enable sin, cos op for QNN HTP backend #6591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2024
Merged

Enable sin, cos op for QNN HTP backend #6591

merged 1 commit into from
Dec 5, 2024

Conversation

Nick-Wei
Copy link
Contributor

  • add sin / cos to op_builder
  • change quantizer to adopt new operator
  • add test cases for both fp16 & quantized version
  • fix bug in capture_program

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 31, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6591

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit d84615a with merge base ac8bf78 (image):

NEW FAILURE - The following job has failed:

  • pull / unittest-arm / linux-job (gh)
    RuntimeError: Command docker exec -t a855da20250f9cc3b940f86ad703f53038b0860a13b62afcf3f6d4ac501a8f75 /exec failed with exit code 1

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

Hi @Nick-Wei!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@Nick-Wei
Copy link
Contributor Author

Hi @haowhsu-quic, this PR enables sin, cos operator which are used in my own model and I also fix a bug related to capture_program. Hopefully we could have this merged, thanks.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 1, 2024
@Nick-Wei Nick-Wei force-pushed the op_enablement branch 2 times, most recently from f6b9077 to bff3cfa Compare November 19, 2024 06:57
haowhsu-quic
haowhsu-quic reviewed Nov 19, 2024
View reviewed changes
backends/arm/third-party/ethos-u-core-driver Outdated
Copy link
Collaborator

@haowhsu-quic haowhsu-quic Nov 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please perform git submodule update and label your PR as requested, thanks.

@Nick-Wei
Copy link
Contributor Author

Hi, @haowhsu-quic, this PR enables the sin and cos operators, which are used in my own model. Additionally, I have added a description for the build_executorch_binary function.

@Nick-Wei
Copy link
Contributor Author

@pytorchbot label "release notes: Added support for sin and cos operations"

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 19, 2024

Didn't find following labels among repository labels: release notes: Added support for sin and cos operations

@Nick-Wei
Copy link
Contributor Author

@pytorchbot label "release notes: feature"

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 19, 2024

Didn't find following labels among repository labels: release notes: feature

@Nick-Wei
Copy link
Contributor Author

@pytorchbot label "feature"

@pytorch-bot pytorch-bot bot added the feature label Nov 19, 2024
haowhsu-quic
haowhsu-quic reviewed Nov 20, 2024
View reviewed changes
backends/qualcomm/utils/utils.py Outdated
@@ -299,6 +299,7 @@ def get_decomp_table() -> Dict[torch._ops.OperatorBase, Callable]:
def _transform(
edge_program: ExportedProgram, custom_pass_config: FrozenSet[str] = frozenset()
) -> ExportedProgram:
custom_pass_config = custom_pass_config or {}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since custom_pass_config is now default constructed, could you remove this line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has already been removed, thank you.

@Nick-Wei
Copy link
Contributor Author

@pytorchbot label "feature"

haowhsu-quic
haowhsu-quic approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@haowhsu-quic haowhsu-quic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you.

@Nick-Wei
Enable sin, cos op for QNN HTP backend
d84615a 
- add sin / cos to op_builder
- change quantizer to adopt new operator
- add test cases for both fp16 & quantized version
- write a description for the build_executorch_binary function."
@haowhsu-quic haowhsu-quic mentioned this pull request Dec 5, 2024
Merged
cccclai
cccclai approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops somehow I totally miss the PR, thank you for contributing!

@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cccclai cccclai added partner: qualcomm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Qualcomm release notes: backends [DO NOT USE] Changes to any of the backend delegates labels Dec 5, 2024
@cccclai cccclai merged commit 5b2129e into pytorch:main Dec 5, 2024
41 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cccclai cccclai cccclai approved these changes

@haowhsu-quic haowhsu-quic haowhsu-quic approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: qualcomm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Qualcomm release notes: backends [DO NOT USE] Changes to any of the backend delegates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Nick-Wei @facebook-github-bot @cccclai @haowhsu-quic