[executorch][serialization] Rename scalar_type.fbs --> common.fbs #6678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

lucylq wants to merge 6 commits into gh/lucylq/15/base from gh/lucylq/15/head

Contributor

lucylq commented Nov 5, 2024 •

edited

Loading

Stack from ghstack (oldest at bottom):

-> [executorch][serialization] Rename scalar_type.fbs --> common.fbs #6678

Allow us to add other shared flatbuffer types into common.fbs.

Rename scalar_type.fbs --> common.fbs
Rename scalar_type.py --> common_schema.py (differentiate from exir/common.py)

Differential Revision: D65442256


          [executorch][serialization] Rename scalar_type.fbs --> common.fbs

71de9ad

Allow us to add other shared flatbuffer types into `common.fbs`.

- Rename scalar_type.fbs --> common.fbs
- Rename scalar_type.py --> common_schema.py (differentiate from exir/common.py)

Differential Revision: [D65442256](https://our.internmc.facebook.com/intern/diff/D65442256/)

[ghstack-poisoned]

pytorch-bot bot commented Nov 5, 2024 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6678

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit b894783 with merge base dc41596 ():

NEW FAILURES - The following jobs have failed:

Lint / lintrunner / linux-job (gh)
>>> Lint for exir/scalar_type.py:
Propose to merge ghstack orig PRs to main / Try to create a PR with ghstack /orig branch (gh)
github.GithubException.GithubException: 404 {"message": "Branch not found", "documentation_url": "https://docs.github.com/rest/branches/branches#get-a-branch", "status": "404"}
pull / unittest / linux / linux-job (gh)
extension/llm/modules/test/test_mha.py::AttentionTest::test_attention_executorch

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot added the CLA Signed label

Contributor

facebook-github-bot commented Nov 5, 2024

This pull request was exported from Phabricator. Differential Revision: D65442256

facebook-github-bot added the fb-exported label

This was referenced Nov 5, 2024

[executorch][serialization] Move DataSegment into shared common.fbs #6679

Closed

[executorch][serialization] Format program.fbs with consistent whitespace #6680

Merged


          Update on "[executorch][serialization] Rename scalar_type.fbs --> com…

8ba5b36

…mon.fbs"

Allow us to add other shared flatbuffer types into `common.fbs`.

- Rename scalar_type.fbs --> common.fbs
- Rename scalar_type.py --> common_schema.py (differentiate from exir/common.py)

Differential Revision: [D65442256](https://our.internmc.facebook.com/intern/diff/D65442256/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Nov 5, 2024

This pull request was exported from Phabricator. Differential Revision: D65442256

lucylq added a commit that referenced this pull request


          [executorch][serialization] Rename scalar_type.fbs --> common.fbs

ded4396

Pull Request resolved: #6678

Allow us to add other shared flatbuffer types into `common.fbs`.

- Rename scalar_type.fbs --> common.fbs
- Rename scalar_type.py --> common_schema.py (differentiate from exir/common.py)
ghstack-source-id: 251992035
@exported-using-ghexport

Differential Revision: [D65442256](https://our.internmc.facebook.com/intern/diff/D65442256/)


          Update on "[executorch][serialization] Rename scalar_type.fbs --> com…

c4a9a3b

…mon.fbs"

Allow us to add other shared flatbuffer types into `common.fbs`.

- Rename scalar_type.fbs --> common.fbs
- Rename scalar_type.py --> common_schema.py (differentiate from exir/common.py)

Differential Revision: [D65442256](https://our.internmc.facebook.com/intern/diff/D65442256/)

[ghstack-poisoned]

lucylq added a commit that referenced this pull request


          [executorch][serialization] Rename scalar_type.fbs --> common.fbs

69d67eb

Pull Request resolved: #6678

Allow us to add other shared flatbuffer types into `common.fbs`.

- Rename scalar_type.fbs --> common.fbs
- Rename scalar_type.py --> common_schema.py (differentiate from exir/common.py)
ghstack-source-id: 251999112
@exported-using-ghexport

Differential Revision: [D65442256](https://our.internmc.facebook.com/intern/diff/D65442256/)

Contributor

facebook-github-bot commented Nov 5, 2024

This pull request was exported from Phabricator. Differential Revision: D65442256


          Update on "[executorch][serialization] Rename scalar_type.fbs --> com…

cdf4929

…mon.fbs"

Allow us to add other shared flatbuffer types into `common.fbs`.

- Rename scalar_type.fbs --> common.fbs
- Rename scalar_type.py --> common_schema.py (differentiate from exir/common.py)

Differential Revision: [D65442256](https://our.internmc.facebook.com/intern/diff/D65442256/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Nov 12, 2024

This pull request was exported from Phabricator. Differential Revision: D65442256

lucylq added a commit that referenced this pull request


          [executorch][serialization] Rename scalar_type.fbs --> common.fbs

0afda4a

Pull Request resolved: #6678

Allow us to add other shared flatbuffer types into `common.fbs`.

- Rename scalar_type.fbs --> common.fbs
- Rename scalar_type.py --> common_schema.py (differentiate from exir/common.py)
ghstack-source-id: 253115112
@exported-using-ghexport

Differential Revision: [D65442256](https://our.internmc.facebook.com/intern/diff/D65442256/)

lucylq mentioned this pull request

Introduce data schema to store raw tensors #6540

Merged

dbort approved these changes

View reviewed changes


          Update on "[executorch][serialization] Rename scalar_type.fbs --> com…

bbf4780

…mon.fbs"

Allow us to add other shared flatbuffer types into `common.fbs`.

- Rename scalar_type.fbs --> common.fbs
- Rename scalar_type.py --> common_schema.py (differentiate from exir/common.py)

Differential Revision: [D65442256](https://our.internmc.facebook.com/intern/diff/D65442256/)

[ghstack-poisoned]

lucylq added a commit that referenced this pull request


          [executorch][serialization] Rename scalar_type.fbs --> common.fbs

a87202c

Pull Request resolved: #6678

Allow us to add other shared flatbuffer types into `common.fbs`.

- Rename scalar_type.fbs --> common.fbs
- Rename scalar_type.py --> common_schema.py (differentiate from exir/common.py)
ghstack-source-id: 253177114
@exported-using-ghexport

Differential Revision: [D65442256](https://our.internmc.facebook.com/intern/diff/D65442256/)

Contributor

facebook-github-bot commented Nov 12, 2024

This pull request was exported from Phabricator. Differential Revision: D65442256


          Update on "[executorch][serialization] Rename scalar_type.fbs --> com…

b894783

…mon.fbs"

Allow us to add other shared flatbuffer types into `common.fbs`.

- Rename scalar_type.fbs --> common.fbs
- Rename scalar_type.py --> common_schema.py (differentiate from exir/common.py)

Differential Revision: [D65442256](https://our.internmc.facebook.com/intern/diff/D65442256/)

[ghstack-poisoned]

lucylq added a commit that referenced this pull request


          [executorch][serialization] Rename scalar_type.fbs --> common.fbs

85c8b00

Pull Request resolved: #6678

Allow us to add other shared flatbuffer types into `common.fbs`.

- Rename scalar_type.fbs --> common.fbs
- Rename scalar_type.py --> common_schema.py (differentiate from exir/common.py)
ghstack-source-id: 253184608
@exported-using-ghexport

Differential Revision: [D65442256](https://our.internmc.facebook.com/intern/diff/D65442256/)

Contributor

facebook-github-bot commented Nov 12, 2024

This pull request was exported from Phabricator. Differential Revision: D65442256

lucylq closed this

lucylq had a problem deploying to cherry-pick-bot

November 12, 2024 23:38

— with

GitHub Actions Failure

lucylq deleted the gh/lucylq/15/head branch

January 24, 2025 19:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported