Use std::variant to implement pytree Key #6701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Key was a struct that should've been a union; std::variant makes using a union much easier. Differential Revision: [D65575184](https://our.internmc.facebook.com/intern/diff/D65575184/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6701
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit fc103c0 with merge base dc41596 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
swolchok
added a commit
that referenced
this pull request
Nov 7, 2024
Key was a struct that should've been a union; std::variant makes using a union much easier. Differential Revision: [D65575184](https://our.internmc.facebook.com/intern/diff/D65575184/) ghstack-source-id: 252232728 Pull Request resolved: #6701
|
This pull request was exported from Phabricator. Differential Revision: D65575184 |
Key was a struct that should've been a union; std::variant makes using a union much easier. Differential Revision: [D65575184](https://our.internmc.facebook.com/intern/diff/D65575184/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D65575184 |
kimishpatel
approved these changes
Nov 7, 2024
Key was a struct that should've been a union; std::variant makes using a union much easier. Differential Revision: [D65575184](https://our.internmc.facebook.com/intern/diff/D65575184/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D65575184 |
Key was a struct that should've been a union; std::variant makes using a union much easier. Differential Revision: [D65575184](https://our.internmc.facebook.com/intern/diff/D65575184/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D65575184 |
Key was a struct that should've been a union; std::variant makes using a union much easier. Differential Revision: [D65575184](https://our.internmc.facebook.com/intern/diff/D65575184/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D65575184 |
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
swolchok
added a commit
that referenced
this pull request
Nov 12, 2024
Pull Request resolved: #6701 Key was a struct that should've been a union; std::variant makes using a union much easier. ghstack-source-id: 253128071 @exported-using-ghexport Differential Revision: [D65575184](https://our.internmc.facebook.com/intern/diff/D65575184/) Co-authored-by: Scott Wolchok <[email protected]>
swolchok
added a commit
that referenced
this pull request
Nov 12, 2024
* Use std::variant to implement pytree Key Pull Request resolved: #6701 Key was a struct that should've been a union; std::variant makes using a union much easier. ghstack-source-id: 253128071 @exported-using-ghexport Differential Revision: [D65575184](https://our.internmc.facebook.com/intern/diff/D65575184/) * Fix missing move and bare new in pytree from_str_internal Just a couple minor fixes. Differential Revision: [D65576543](https://our.internmc.facebook.com/intern/diff/D65576543/) ghstack-source-id: 253128072 Pull Request resolved: #6783 --------- Co-authored-by: Scott Wolchok <[email protected]>
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
Pull Request resolved: pytorch/executorch#6701 Key was a struct that should've been a union; std::variant makes using a union much easier. ghstack-source-id: 252630473 @exported-using-ghexport Differential Revision: [D65575184](https://our.internmc.facebook.com/intern/diff/D65575184/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Key was a struct that should've been a union; std::variant makes using a union much easier.
Differential Revision: D65575184