migrate passes calls to pass utils #6721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6721
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b5febc0 with merge base dc41596 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65464704 |
zonglinpeng
force-pushed
the
export-D65464704
branch
from
659d7ed to
bb6be76
Compare
zonglinpeng
added a commit
to zonglinpeng/executorch
that referenced
this pull request
Nov 12, 2024
Summary: keep the same calling order in oss, but calling by pass util pass register Reviewed By: hsharma35 Differential Revision: D65464704
|
This pull request was exported from Phabricator. Differential Revision: D65464704 |
zonglinpeng
added a commit
to zonglinpeng/executorch
that referenced
this pull request
Nov 12, 2024
Summary: keep the same calling order in oss, but calling by pass util pass register Reviewed By: hsharma35 Differential Revision: D65464704
zonglinpeng
force-pushed
the
export-D65464704
branch
from
bb6be76 to
d4f7083
Compare
Summary: keep the same calling order in oss, but calling by pass util pass register Reviewed By: hsharma35 Differential Revision: D65464704
zonglinpeng
force-pushed
the
export-D65464704
branch
from
d4f7083 to
b5febc0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65464704 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D65464704 |
hsharma35
approved these changes
Nov 12, 2024
| srcs = [ | ||
| "_passes.py", | ||
| "pass_utils.py", |
There was a problem hiding this comment.
@tarun292 do we need the _ here? I forgot the exact reason to add it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: keep the same calling order in oss, but calling by pass util pass register
Differential Revision: D65464704