Fix flaky ET attention test #6795
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Torch's manual seed is environment-based,
loosen the tol for torch.allcloseuse assert_close instead which sets an appropriate atol and rtol based on the dtype, since the previous tol was too strict.Fixes flaky mha test and reverts #6790.
Test plan
Confirmed and reproduced locally by altering the manual seed until there was an issue. Modified unit test to pass locally.