Skip to content

Fix flaky ET attention test #6795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Fix flaky ET attention test #6795

merged 3 commits into from
Nov 12, 2024

Conversation

jackzhxng
Copy link
Contributor

@jackzhxng jackzhxng commented Nov 12, 2024

Summary

Torch's manual seed is environment-based, loosen the tol for torch.allclose use assert_close instead which sets an appropriate atol and rtol based on the dtype, since the previous tol was too strict.

Fixes flaky mha test and reverts #6790.

Test plan

Confirmed and reproduced locally by altering the manual seed until there was an issue. Modified unit test to pass locally.

Copy link

pytorch-bot bot commented Nov 12, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6795

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a1baf0d with merge base 9cd57d6 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 12, 2024
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
@larryliu0820 larryliu0820 merged commit f943856 into main Nov 12, 2024
38 checks passed
@larryliu0820 larryliu0820 deleted the jz/fix-flaky-mha-test branch November 12, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants