Skip to content

[llama-mm] Enable kv cache for MultiHeadAttention #6798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2024
Merged

[llama-mm] Enable kv cache for MultiHeadAttention #6798

merged 1 commit into from
Nov 12, 2024

Conversation

pytorchbot
Copy link
Collaborator

@pytorchbot pytorchbot commented Nov 12, 2024 •
edited by kirklandsign
Loading

This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #6793
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/larryliu0820/55/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/larryliu0820/55/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/larryliu0820/55/orig

@larryliu0820
[llama-mm] Enable kv cache for MultiHeadAttention
ab90d92 
Summary: Change `MultiHeadAttention` in `extension/llm/modules` to
support KV cache. Only enable eager but not export yet.

Test Plan: Unit test

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: ded3830
Pull Request resolved: #6793
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 12, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6798

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit ab90d92 with merge base 4947e27 (image):

NEW FAILURE - The following job has failed:

  • pull / android / run-emulator (gh)
    adb: failed to install android-test-debug.apk: Failure [INSTALL_PARSE_FAILED_NOT_APK: Failed to parse /data/app/vmdl313180744.tmp/base.apk: Failed to load asset path /data/app/vmdl313180744.tmp/base.apk]

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 12, 2024
@larryliu0820 larryliu0820 merged commit 9cd57d6 into main Nov 12, 2024
38 of 39 checks passed
@larryliu0820 larryliu0820 deleted the gh/larryliu0820/55/orig branch November 12, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larryliu0820 larryliu0820 larryliu0820 approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pytorchbot @larryliu0820 @facebook-github-bot