expand dtype conversion support in aten_bridge #6845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6845
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New FailureAs of commit 9c101af with merge base d9d4859 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65897501 |
JacobSzwejbka
added a commit
to JacobSzwejbka/executorch-1
that referenced
this pull request
Nov 14, 2024
Summary: Pull Request resolved: pytorch#6845 The dtype tables by necessity have to match exaclty so just casting to the int and then recasting to the other enum is safe Reviewed By: dulinriley Differential Revision: D65897501
JacobSzwejbka
force-pushed
the
export-D65897501
branch
from
f13050d to
7ec95a9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65897501 |
Summary: The dtype tables by necessity have to match exaclty so just casting to the int and then recasting to the other enum is safe Reviewed By: dulinriley Differential Revision: D65897501
JacobSzwejbka
force-pushed
the
export-D65897501
branch
from
7ec95a9 to
9c101af
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65897501 |
tarun292
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The dtype tables by necessity have to match exaclty so just casting to the int and then recasting to the other enum is safe
Differential Revision: D65897501