Add unit tests for old lowering flow for op_cat.py #6847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6847
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65914291 |
suchir1
force-pushed
the
export-D65914291
branch
from
a2fffb7 to
94457f0
Compare
suchir1
added a commit
to suchir1/executorch
that referenced
this pull request
Nov 14, 2024
Summary: The team moved to leveraging a new API which allows them to improve the reliability of our lowering infra. Lowering here refers to converting a PyTorch model that's recognizable by the underlying hardware. This diff makes sure there are still unit tests for the older APIs. (done as a bootcamp task, all comments welcome!) Reviewed By: mcr229 Differential Revision: D65914291
|
This pull request was exported from Phabricator. Differential Revision: D65914291 |
suchir1
added a commit
to suchir1/executorch
that referenced
this pull request
Nov 14, 2024
Summary: The team moved to leveraging a new API which allows them to improve the reliability of our lowering infra. Lowering here refers to converting a PyTorch model that's recognizable by the underlying hardware. This diff makes sure there are still unit tests for the older APIs. Reviewed By: mcr229 Differential Revision: D65914291
suchir1
force-pushed
the
export-D65914291
branch
from
94457f0 to
1be038d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65914291 |
suchir1
force-pushed
the
export-D65914291
branch
from
1be038d to
c20bbb0
Compare
suchir1
added a commit
to suchir1/executorch
that referenced
this pull request
Nov 14, 2024
Summary: The team moved to leveraging a new API which allows them to improve the reliability of our lowering infra. Lowering here refers to converting a PyTorch model that's recognizable by the underlying hardware. This diff makes sure there are still unit tests for the older APIs. Reviewed By: mcr229 Differential Revision: D65914291
|
This pull request was exported from Phabricator. Differential Revision: D65914291 |
mcr229
approved these changes
Nov 14, 2024
Summary: The team moved to leveraging a new API which allows them to improve the reliability of our lowering infra. Lowering here refers to converting a PyTorch model that's recognizable by the underlying hardware. This diff makes sure there are still unit tests for the older APIs. Reviewed By: mcr229 Differential Revision: D65914291
suchir1
force-pushed
the
export-D65914291
branch
from
c20bbb0 to
956d70c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65914291 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The team moved to leveraging a new API which allows them to improve the reliability of our lowering infra. Lowering here refers to converting a PyTorch model that's recognizable by the underlying hardware. This diff makes sure there are still unit tests for the older APIs.
Reviewed By: mcr229
Differential Revision: D65914291