Remove <model>.pte generation from export_bundled_program.py #692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Currently, this script generates two files: - `<model>.pte` after calling `save_pte_program` - `<model>.bp` after calling `save_bundled_program` Since this example is intended to showcase the functionality of the bundled program, we shouldn't generate `<model>.pte` -- only `<model>.bp`. We should also rename the function to reflect this. Gasoonjia tarun292 do you agree w/ the above? Just a small thought I had while using this. Reviewed By: tarun292, Gasoonjia Differential Revision: D50069707
✅ Deploy Preview for resplendent-gnome-14e531 canceled.
|
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D50069707 |
|
This pull request has been merged in b602439. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Currently, this script generates two files:
<model>.pteafter callingsave_pte_program<model>.bpafter callingsave_bundled_programSince this example is intended to showcase the functionality of the bundled program, we shouldn't generate
<model>.pte-- only<model>.bp.We should also rename the function to reflect this.
Gasoonjia tarun292 do you agree w/ the above? Just a small thought I had while using this.
Reviewed By: tarun292, Gasoonjia
Differential Revision: D50069707