Take advantage of C++17 in scalar_type_util.h #6968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I generated a big ugly table because we couldn't make promoteTypes constexpr before we had C++17. Now we have C++17. Differential Revision: [D66181946](https://our.internmc.facebook.com/intern/diff/D66181946/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6968
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 0e992c6 with merge base 43555d2 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
swolchok
added a commit
that referenced
this pull request
Nov 19, 2024
I generated a big ugly table because we couldn't make promoteTypes constexpr before we had C++17. Now we have C++17. Differential Revision: [D66181946](https://our.internmc.facebook.com/intern/diff/D66181946/) ghstack-source-id: 254388438 Pull Request resolved: #6968
|
This pull request was exported from Phabricator. Differential Revision: D66181946 |
I generated a big ugly table because we couldn't make promoteTypes constexpr before we had C++17. Now we have C++17. Differential Revision: [D66181946](https://our.internmc.facebook.com/intern/diff/D66181946/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Nov 19, 2024
Pull Request resolved: #6968 I generated a big ugly table because we couldn't make promoteTypes constexpr before we had C++17. Now we have C++17. Differential Revision: [D66181946](https://our.internmc.facebook.com/intern/diff/D66181946/) ghstack-source-id: 254409669
|
This pull request was exported from Phabricator. Differential Revision: D66181946 |
dbort
approved these changes
Nov 19, 2024
malfet
approved these changes
Nov 19, 2024
I generated a big ugly table because we couldn't make promoteTypes constexpr before we had C++17. Now we have C++17. Differential Revision: [D66181946](https://our.internmc.facebook.com/intern/diff/D66181946/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Nov 20, 2024
Pull Request resolved: #6968 I generated a big ugly table because we couldn't make promoteTypes constexpr before we had C++17. Now we have C++17. ghstack-source-id: 254479808 Differential Revision: [D66181946](https://our.internmc.facebook.com/intern/diff/D66181946/)
|
This pull request was exported from Phabricator. Differential Revision: D66181946 |
I generated a big ugly table because we couldn't make promoteTypes constexpr before we had C++17. Now we have C++17. Differential Revision: [D66181946](https://our.internmc.facebook.com/intern/diff/D66181946/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Nov 20, 2024
Pull Request resolved: #6968 I generated a big ugly table because we couldn't make promoteTypes constexpr before we had C++17. Now we have C++17. ghstack-source-id: 254597889 Differential Revision: [D66181946](https://our.internmc.facebook.com/intern/diff/D66181946/)
|
This pull request was exported from Phabricator. Differential Revision: D66181946 |
I generated a big ugly table because we couldn't make promoteTypes constexpr before we had C++17. Now we have C++17. Differential Revision: [D66181946](https://our.internmc.facebook.com/intern/diff/D66181946/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Nov 20, 2024
Pull Request resolved: #6968 I generated a big ugly table because we couldn't make promoteTypes constexpr before we had C++17. Now we have C++17. ghstack-source-id: 254600078 Differential Revision: [D66181946](https://our.internmc.facebook.com/intern/diff/D66181946/)
|
This pull request was exported from Phabricator. Differential Revision: D66181946 |
I generated a big ugly table because we couldn't make promoteTypes constexpr before we had C++17. Now we have C++17. Differential Revision: [D66181946](https://our.internmc.facebook.com/intern/diff/D66181946/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Nov 21, 2024
Pull Request resolved: #6968 I generated a big ugly table because we couldn't make promoteTypes constexpr before we had C++17. Now we have C++17. ghstack-source-id: 254805946 Differential Revision: [D66181946](https://our.internmc.facebook.com/intern/diff/D66181946/)
|
This pull request was exported from Phabricator. Differential Revision: D66181946 |
swolchok
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
swolchok
added a commit
that referenced
this pull request
Nov 21, 2024
Pull Request resolved: #6968 I generated a big ugly table because we couldn't make promoteTypes constexpr before we had C++17. Now we have C++17. ghstack-source-id: 254805946 Differential Revision: [D66181946](https://our.internmc.facebook.com/intern/diff/D66181946/) Co-authored-by: Scott Wolchok <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
I generated a big ugly table because we couldn't make promoteTypes constexpr before we had C++17. Now we have C++17.
Differential Revision: D66181946