Skip to content

Fix ARM submodule URLs #6973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Fix ARM submodule URLs #6973

merged 1 commit into from
Nov 20, 2024

Conversation

swolchok
Copy link
Contributor

Looks like review.mlplatform.org is no longer hosting these things and these are the new URLs.

Test Plan: git submodule update --init (did nothing in my existing checkout)

Looks like review.mlplatform.org is no longer hosting these things and these are the new URLs.
Copy link

pytorch-bot bot commented Nov 19, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6973

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 690d2ee with merge base 809a1a5 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 19, 2024
@swolchok swolchok merged commit f40daea into main Nov 20, 2024
41 of 43 checks passed
@swolchok swolchok deleted the fix-submodules branch November 20, 2024 00:42
@digantdesai digantdesai added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Nov 20, 2024
@digantdesai
Copy link
Contributor

FYI @robell, @freddan80

@robell
Copy link
Collaborator

robell commented Nov 20, 2024

Hi @digantdesai and @swolchok - Sorry about all of the issues relating to this.

review.* and git.* are hosted on the same machine, and typically/by design the review.mlplatform.org software is more reliable for cloning the repositories.

There were capacity issues on the machine due to a third party github flow which are now resolved by adding capacity to the VM, so it's recommended to move back to review.mlplatform.org. This should now be reliably available again. We may prefer to leave this alone now if it's functioning, but just be aware of the option.

In addition, we'll be looking to mirror these dependencies to more scalable/reliable hosting and move the submodule fetches to that host. I'll get a PR up once those mirrors are available, I'm just clarifying how soon that can happen.

swolchok added a commit that referenced this pull request Nov 20, 2024
Apparently the `review.` URLs are preferred due to lower resource usage.

Differential Revision: [D66247100](https://our.internmc.facebook.com/intern/diff/D66247100/)

[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

recommended to move back to review.mlplatform.org

I sent #6987, but review. URLs appear to still be down given CI failures on that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants