Clear out Dynamo cache in between tests #6990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This issue was discovered when we tried to land https://www.internalfb.com/diff/D66189091. There is nothing wrong with D66189091, it just changes the way Dynamo invalidates its cache entry. However, it upsets these tests because they unintentionally rely on the Dynamo old behavior of invalidting cache entries. Reviewed By: kimishpatel Differential Revision: D66255174
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6990
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 5 New Failures, 2 Unrelated FailuresAs of commit 9110c76 with merge base 359e9d3 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66255174 |
izaitsevfb
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This issue was discovered when we tried to land https://www.internalfb.com/diff/D66189091. There is nothing wrong with D66189091, it just changes the way Dynamo invalidates its cache entry. However, it upsets these tests because they unintentionally rely on the Dynamo old behavior of invalidting cache entries.
Reviewed By: kimishpatel
Differential Revision: D66255174