Fix compilation crash on iOS<16 #7007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Added conditional compilation to mitigate a crash on iOS<16 where the used function is not present. Fixes pytorch#6984 Bonus: report back the error in case of compilation errors, which was missing Differential Revision: D66294248
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7007
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 3 New FailuresAs of commit 8f75eef with merge base 270d055 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66294248 |
|
@pytorchbot label "module: coreml" |
pytorch-bot
bot
added
the
module: coreml
|
@pytorchbot label "release notes: backends" |
pytorch-bot
bot
added
the
release notes: backends [DO NOT USE]
f-meloni
commented
Nov 21, 2024
| return nil; | ||
| } | ||
| } else { | ||
| result = [MLModel compileModelAtURL:modelURL error:&localError]; |
There was a problem hiding this comment.
This doesn't have the timeout logic, but it was crashing before, so I think we can go with this for now to mitigate the issue and improve it later.
cymbalrush
approved these changes
Nov 22, 2024
|
@cymbalrush Thank you for the review :) I think it is iOS 13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Added conditional compilation to mitigate a crash on iOS<16 where the used function is not present.
Fixes #6984
Bonus: report back the error in case of compilation errors, which was missing
Differential Revision: D66294248