Skip to content

[Android] Remove runtime internal evalue list types #7012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

kirklandsign
Copy link
Contributor

Summary

List types are used in runtime only. Exported model inputs and outputs won't use them. Therefore, we remove them from Java public API.

Test plan

cd extension/android_test/
./gradlew build

@kirklandsign kirklandsign added the release notes: api Changes to public facing apis (any interfaces, pybinded runtime methods, etc.) label Nov 21, 2024
Copy link

pytorch-bot bot commented Nov 21, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7012

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 2ceadac with merge base 6ac19cc (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 21, 2024
Base automatically changed from android-java to main November 21, 2024 20:32
List types are used in runtime only. Exported model inputs and outputs won't
use them. Therefore, we remove them from Java public API.
@kirklandsign kirklandsign force-pushed the android-remove-internal-evalue branch from e4b251d to d877519 Compare November 21, 2024 20:34
@kirklandsign kirklandsign merged commit 2adb1bc into main Nov 21, 2024
40 checks passed
@kirklandsign kirklandsign deleted the android-remove-internal-evalue branch November 21, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: api Changes to public facing apis (any interfaces, pybinded runtime methods, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants