[ET][Portable] Simplify op copy #711
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fact that `src` must broadcast to `in` implies that the result of broadcasting `in` and `src` has shape equal to `in`. Therefore `out` must have the same shape than `in`. Hence, we can avoid calling `get_broadcast_target_size` and simply resize `out` to `in.sizes()` Differential Revision: [D49979519](https://our.internmc.facebook.com/intern/diff/D49979519/) [ghstack-poisoned]
facebook-github-bot
added
the
CLA Signed
This was referenced Oct 9, 2023
The fact that `src` must broadcast to `in` implies that the result of broadcasting `in` and `src` has shape equal to `in`. Therefore `out` must have the same shape than `in`. Hence, we can avoid calling `get_broadcast_target_size` and simply resize `out` to `in.sizes()` Differential Revision: [D49979519](https://our.internmc.facebook.com/intern/diff/D49979519/) [ghstack-poisoned]
This was referenced Oct 9, 2023
|
This pull request has been merged in 7a7f9dd. |
This was referenced Oct 10, 2023
Gasoonjia
pushed a commit
that referenced
this pull request
Jul 30, 2024
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
Pull Request resolved: pytorch/executorch#711 The fact that `src` must broadcast to `in` implies that the result of broadcasting `in` and `src` has shape equal to `in`. Therefore `out` must have the same shape than `in`. Hence, we can avoid calling `get_broadcast_target_size` and simply resize `out` to `in.sizes()` ghstack-source-id: 203404905 @exported-using-ghexport Differential Revision: [D49979519](https://our.internmc.facebook.com/intern/diff/D49979519/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
The fact that
srcmust broadcast toinimplies that the result of broadcastinginandsrchas shape equal toin. Thereforeoutmust have the same shape thanin. Hence, we can avoid callingget_broadcast_target_sizeand simply resizeouttoin.sizes()Differential Revision: D49979519