[ET-VK] Store unique ptr to Tensor in Value instead of inlined tensor object, to reduce Value struct size from 448 to 80 bytes. #7145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… object, to reduce Value struct size from 448 to 80 bytes. This diff aims to reduce the size of the Value struct in the Executorch Vulkan runtime by storing a unique pointer to the Tensor object instead of an inlined tensor object. This change reduces the size of the Value struct from 448 bytes to 80 bytes, which can improve performance and reduce memory usage. Differential Revision: [D66655991](https://our.internmc.facebook.com/intern/diff/D66655991/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7145
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit cee5e89 with merge base 63238ab ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This was referenced Dec 2, 2024
Merged
|
This pull request was exported from Phabricator. Differential Revision: D66655991 |
trivedivivek
added a commit
that referenced
this pull request
Dec 2, 2024
… object, to reduce Value struct size from 448 to 80 bytes. This diff aims to reduce the size of the Value struct in the Executorch Vulkan runtime by storing a unique pointer to the Tensor object instead of an inlined tensor object. This change reduces the size of the Value struct from 448 bytes to 80 bytes, which can improve performance and reduce memory usage. Differential Revision: [D66655991](https://our.internmc.facebook.com/intern/diff/D66655991/) ghstack-source-id: 256050917 Pull Request resolved: #7145
jorgep31415
approved these changes
Dec 2, 2024
…ined tensor object, to reduce Value struct size from 448 to 80 bytes." This diff aims to reduce the size of the Value struct in the Executorch Vulkan runtime by storing a unique pointer to the Tensor object instead of an inlined tensor object. This change reduces the size of the Value struct from 448 bytes to 80 bytes, which can improve performance and reduce memory usage. Differential Revision: [D66655991](https://our.internmc.facebook.com/intern/diff/D66655991/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D66655991 |
trivedivivek
added
the
release notes: backends [DO NOT USE]
…ined tensor object, to reduce Value struct size from 448 to 80 bytes." This diff aims to reduce the size of the Value struct in the Executorch Vulkan runtime by storing a unique pointer to the Tensor object instead of an inlined tensor object. This change reduces the size of the Value struct from 448 bytes to 80 bytes, which can improve performance and reduce memory usage. Differential Revision: [D66655991](https://our.internmc.facebook.com/intern/diff/D66655991/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D66655991 |
…ined tensor object, to reduce Value struct size from 448 to 80 bytes." This diff aims to reduce the size of the Value struct in the Executorch Vulkan runtime by storing a unique pointer to the Tensor object instead of an inlined tensor object. This change reduces the size of the Value struct from 448 bytes to 80 bytes, which can improve performance and reduce memory usage. Differential Revision: [D66655991](https://our.internmc.facebook.com/intern/diff/D66655991/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D66655991 |
…ined tensor object, to reduce Value struct size from 448 to 80 bytes." This diff aims to reduce the size of the Value struct in the Executorch Vulkan runtime by storing a unique pointer to the Tensor object instead of an inlined tensor object. This change reduces the size of the Value struct from 448 bytes to 80 bytes, which can improve performance and reduce memory usage. Differential Revision: [D66655991](https://our.internmc.facebook.com/intern/diff/D66655991/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D66655991 |
This was referenced Dec 6, 2024
Merged
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
This was referenced Dec 6, 2024
kirklandsign
pushed a commit
that referenced
this pull request
Dec 9, 2024
… object, to reduce Value struct size from 448 to 80 bytes. Pull Request resolved: #7145 This diff aims to reduce the size of the Value struct in the Executorch Vulkan runtime by storing a unique pointer to the Tensor object instead of an inlined tensor object. This change reduces the size of the Value struct from 448 bytes to 80 bytes, which can improve performance and reduce memory usage. ghstack-source-id: 256911524 @exported-using-ghexport Differential Revision: [D66655991](https://our.internmc.facebook.com/intern/diff/D66655991/) --------- Co-authored-by: Vivek Trivedi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This diff aims to reduce the size of the Value struct in the Executorch Vulkan runtime by storing a unique pointer to the Tensor object instead of an inlined tensor object. This change reduces the size of the Value struct from 448 bytes to 80 bytes, which can improve performance and reduce memory usage.
Differential Revision: D66655991