Skip to content

[ET-VK] Adding UniformData struct in vTensor class to store uniform data, which will be stored using shared ptr and can be shared with push constants. #7251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

pytorchbot
Copy link
Collaborator

This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #7222
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/21/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/21/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/20/orig
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/21/orig
@diff-train-skip-merge

Copy link

pytorch-bot bot commented Dec 9, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7251

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 38b272c with merge base e34d724 (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 9, 2024
@kirklandsign kirklandsign force-pushed the gh/trivedivivek/20/orig branch from 7410887 to 85c4a4e Compare December 10, 2024 06:16
Base automatically changed from gh/trivedivivek/20/orig to main December 10, 2024 06:16
…ata, which will be stored using shared ptr and can be shared with push constants.

Pull Request resolved: #7222

This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor.

Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders.

The diff also adds write_attribute function to UniformData class to write attribute data to a given memory.
ghstack-source-id: 257227242
@exported-using-ghexport

Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/)
@kirklandsign kirklandsign force-pushed the gh/trivedivivek/21/orig branch from 44f3ed9 to 38b272c Compare December 10, 2024 06:17
@kirklandsign kirklandsign added the release notes: backends [DO NOT USE] Changes to any of the backend delegates label Dec 10, 2024
@kirklandsign kirklandsign merged commit f6a87ac into main Dec 10, 2024
38 of 41 checks passed
@kirklandsign kirklandsign deleted the gh/trivedivivek/21/orig branch December 10, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: backends [DO NOT USE] Changes to any of the backend delegates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants