Remove checks on quant_min/quant_max #7256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7256
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 364c1e5 with merge base f22d1a3 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66912431 |
|
This pull request was exported from Phabricator. Differential Revision: D66912431 |
zonglinpeng
added a commit
to zonglinpeng/executorch
that referenced
this pull request
Dec 9, 2024
Summary: Pull Request resolved: pytorch#7256 As titled. More debugging is needed for the failures, but let's unblock the Cria runs. Reviewed By: abhiag-git, cmt0 Differential Revision: D66912431
zonglinpeng
force-pushed
the
export-D66912431
branch
from
ca433c3 to
e678a70
Compare
Summary: Pull Request resolved: pytorch#7256 As titled. More debugging is needed for the failures, but let's unblock the Cria runs. Reviewed By: abhiag-git, cmt0 Differential Revision: D66912431
zonglinpeng
force-pushed
the
export-D66912431
branch
from
e678a70 to
364c1e5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66912431 |
hsharma35
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: As titled. More debugging is needed for the failures, but let's unblock the Cria runs.
Reviewed By: abhiag-git, cmt0
Differential Revision: D66912431