Skip to content

[Arm tester] Run delegate nodes using tosa_reference_model #7552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

Erik-Lundell
Copy link
Collaborator

Instead of executing just one delegate,
we execute the graph and dispatch the
delegate nodes to the tosa_reference_model.
This makes the tester more flexible and
enables running tests with multiple
delegates, multiple outputs etc.

Copy link

pytorch-bot bot commented Jan 8, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7552

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 87995d0 with merge base 2a4256b (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@Erik-Lundell Erik-Lundell added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Jan 8, 2025
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 8, 2025
@Erik-Lundell Erik-Lundell added topic: not user facing ciflow/trunk and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jan 8, 2025
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 8, 2025
@Erik-Lundell Erik-Lundell marked this pull request as draft January 9, 2025 08:38
@Erik-Lundell Erik-Lundell marked this pull request as ready for review January 10, 2025 10:10
@Erik-Lundell Erik-Lundell marked this pull request as draft January 10, 2025 14:58
@Erik-Lundell Erik-Lundell force-pushed the tosa_dispatch branch 2 times, most recently from c4f4b42 to afd6fbe Compare January 13, 2025 10:14
Signed-off-by: Erik Lundell <[email protected]>
Change-Id: I258c3485ea826b34b97b604dbcb68034608a9114
In most test cases we need the quantized_ops_aot
lib which this flag toggles loading.
Instead, always load the quantized_ops_aot lib,
unless we are only doing collection.

Signed-off-by: Erik Lundell <[email protected]>
Change-Id: I820b5decdf12a5825f4e52a0c0412bbfaf959761
Instead of executing just one delegate,
we execute the graph and dispatch the
delegate nodes to the tosa_reference_model.
This makes the tester more flexible and
enables running tests with multiple
delegates, multiple outputs etc.

Signed-off-by: Erik Lundell <[email protected]>
Change-Id: I5fb0192da2d187f29c025e0c51238a9cb7d7ec90
@Erik-Lundell Erik-Lundell marked this pull request as ready for review January 13, 2025 14:36
@freddan80 freddan80 merged commit a10eabd into pytorch:main Jan 14, 2025
107 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants