Skip to content

Typo in coreml README.md #7586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Typo in coreml README.md #7586

merged 2 commits into from
Jan 14, 2025

Conversation

daniil-lyakhov
Copy link
Contributor

@daniil-lyakhov daniil-lyakhov commented Jan 10, 2025

Summary

Fixed typos in the coreml README.md:

  • model -> source_model
  • torch.int8 -> torch.qint8
  • torch.uint8 -> torch.quint8

Copy link

pytorch-bot bot commented Jan 10, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7586

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit f0e861e with merge base a059981 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

Hi @daniil-lyakhov!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Copy link
Contributor

@lucylq lucylq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the docs!

@lucylq lucylq added the release notes: examples Changes to any of our example LLMs integrations, such as Llama3 and Llava label Jan 11, 2025
@lucylq
Copy link
Contributor

lucylq commented Jan 13, 2025

@daniil-lyakhov , do you mind going through https://code.facebook.com/cla to sign the CLA check, so that we can merge the PR? Thank you!

@lucylq
Copy link
Contributor

lucylq commented Jan 14, 2025

@daniil-lyakhov , do you mind patching #7626 as well? Thanks a lot!

@daniil-lyakhov
Copy link
Contributor Author

@daniil-lyakhov , do you mind patching #7626 as well? Thanks a lot!

Sure! Done

@lucylq lucylq mentioned this pull request Jan 14, 2025
@daniil-lyakhov
Copy link
Contributor Author

@lucylq, I've signed the CLA, hope I did it right

@lucylq
Copy link
Contributor

lucylq commented Jan 14, 2025

@lucylq, I've signed the CLA, hope I did it right

Thanks! The 'Facebook CLA Check' test is still failing, though the process can take up to an hour so let's check in again then.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 14, 2025
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@lucylq
Copy link
Contributor

lucylq commented Jan 14, 2025

linux unittest failure seems to be fixed in main with #7580, merging.

@lucylq lucylq merged commit 8a5f52b into pytorch:main Jan 14, 2025
51 of 52 checks passed
YIWENX14 pushed a commit that referenced this pull request Jan 28, 2025
* Typo in coreml README.md

* int8 -> qint8, uint8 -> quint8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: examples Changes to any of our example LLMs integrations, such as Llama3 and Llava
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants