-
Notifications
You must be signed in to change notification settings - Fork 607
Typo in coreml README.md #7586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typo in coreml README.md #7586
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7586
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit f0e861e with merge base a059981 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Hi @daniil-lyakhov! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the docs!
@daniil-lyakhov , do you mind going through https://code.facebook.com/cla to sign the CLA check, so that we can merge the PR? Thank you! |
@daniil-lyakhov , do you mind patching #7626 as well? Thanks a lot! |
Sure! Done |
@lucylq, I've signed the CLA, hope I did it right |
Thanks! The 'Facebook CLA Check' test is still failing, though the process can take up to an hour so let's check in again then. |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
linux unittest failure seems to be fixed in main with #7580, merging. |
* Typo in coreml README.md * int8 -> qint8, uint8 -> quint8
Summary
Fixed typos in the coreml README.md:
model
->source_model
torch.int8
->torch.qint8
torch.uint8
->torch.quint8