Skip to content

Improve data format handling in Arm backend #7588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Conversation

AdrianLundell
Copy link
Collaborator

  • Updates the Vela version to support TRANSPOSE for EthosU55.
  • Add pass to decompose SELECT into SLICE + SQUEEZE to insert transposes properly
  • Updates affected unittests

These changes removes the need for the permute_memory_to_nhwc flag and removes a lot of expected failures.

- Updates the Vela version to support TRANSPOSE for EthosU55.
- Add pass to decompose SELECT into SLICE + SQUEEZE to insert tranposes properly
- Updates affected unittests

These changes removes the need for the permute_memory_to_nhwc flag and removes a lot of expected failures.

Change-Id: Ia316220ab5f88efb7410f5f1a9a5f693f2354917
@AdrianLundell AdrianLundell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk topic: not user facing labels Jan 10, 2025
Copy link

pytorch-bot bot commented Jan 10, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7588

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 05079de with merge base 3f9324c (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 10, 2025
@AdrianLundell
Copy link
Collaborator Author

Unrelated CI error, looks related to unstable downloads:

Downloading shards:  33% 1/3 [12:10<24:20, 730.09s/it]
  Traceback (most recent call last):
    File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/urllib3/response.py", line 754, in _error_catcher
      yield
    File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/urllib3/response.py", line 900, in _raw_read
      raise IncompleteRead(self._fp_bytes_read, self.length_remaining)
  urllib3.exceptions.IncompleteRead: IncompleteRead(2601384761 bytes read, 2382058663 more expected)

@freddan80 freddan80 merged commit 2a4256b into pytorch:main Jan 13, 2025
106 of 107 checks passed
YIWENX14 pushed a commit that referenced this pull request Jan 28, 2025
- Updates the Vela version to support TRANSPOSE for EthosU55.
- Add pass to decompose SELECT into SLICE + SQUEEZE to insert tranposes properly
- Updates affected unittests

These changes removes the need for the permute_memory_to_nhwc flag and removes a lot of expected failures.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants