Reduce size of Method::parse_types #7613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 10, 2025 13:31
At least one internal build have -Werror -Wunused-variable and ExecuTorch logging disabled. Differential Revision: [D68032964](https://our.internmc.facebook.com/intern/diff/D68032964/) ghstack-source-id: 260945746 Pull Request resolved: #7602
It looks like this function was big enough that inlining gave up, since I was seeing non-inlined calls to val_as_Foo() that should have been easily optimized away. Do said optimization manually. Differential Revision: [D68037113](https://our.internmc.facebook.com/intern/diff/D68037113/) ghstack-source-id: 260959235 Pull Request resolved: #7603
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7613
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 21aa1a7 with merge base e1c0bcf ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
lucylq
approved these changes
Jan 13, 2025
YIWENX14
pushed a commit
that referenced
this pull request
Jan 28, 2025
* add maybe_unused where needed in size_test.cpp At least one internal build have -Werror -Wunused-variable and ExecuTorch logging disabled. Differential Revision: [D68032964](https://our.internmc.facebook.com/intern/diff/D68032964/) ghstack-source-id: 260945746 Pull Request resolved: #7602 * Reduce size of Method::parse_types It looks like this function was big enough that inlining gave up, since I was seeing non-inlined calls to val_as_Foo() that should have been easily optimized away. Do said optimization manually. Differential Revision: [D68037113](https://our.internmc.facebook.com/intern/diff/D68037113/) ghstack-source-id: 260959235 Pull Request resolved: #7603 --------- Co-authored-by: Github Executorch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #7603
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/swolchok/129/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/swolchok/129/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/swolchok/128/orig
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/swolchok/129/orig
@diff-train-skip-merge