Validate value indices when deserializing list types #7637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7637
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit c91d7de with merge base 83c0da5 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68127899 |
Summary: List types contain lists of indices into the method's `values_` list. Ensure that we don't overflow the list when those indices are corrupt. This should guard: - IntList - OptionalTensorList - TensorList The other scalar list types do not do the unboxing that IntList does, so shouldn't run into this problem. Differential Revision: D68127899
dbort
force-pushed
the
export-D68127899
branch
from
5246b8b to
c91d7de
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68127899 |
JacobSzwejbka
approved these changes
Jan 14, 2025
YIWENX14
pushed a commit
that referenced
this pull request
Jan 28, 2025
Differential Revision: D68127899 Pull Request resolved: #7637
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
List types contain lists of indices into the method's
values_list. Ensure that we don't overflow the list when those indices are corrupt. This should guard:The other scalar list types do not do the unboxing that IntList does, so shouldn't run into this problem.
Differential Revision: D68127899