Skip to content

Fix for multiple outputs in FVP tests #7650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 17, 2025
Merged

Fix for multiple outputs in FVP tests #7650

merged 2 commits into from
Jan 17, 2025

Conversation

SaoirseARM
Copy link
Collaborator

Summary

  • Update to ensure all output nodes are consumed.
  • Update to ensure output quantization scales are used.

@SaoirseARM
Fix for multiple outputs in corstone
0f62de2 
- Update to ensure all output nodes are consumed.
- Update to ensure output quant scales are used.
@SaoirseARM SaoirseARM requested a review from freddan80 January 14, 2025 13:09
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jan 14, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7650

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 172a3ba with merge base 0dba025 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 14, 2025
@SaoirseARM
Copy link
Collaborator Author

@pytorchbot label ciflow/trunk

@SaoirseARM
Copy link
Collaborator Author

@pytorchbot label 'partner: arm'

@pytorch-bot pytorch-bot bot added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Jan 14, 2025
@SaoirseARM
Copy link
Collaborator Author

@pytorchbot label "topic: not user facing"

@freddan80
Copy link
Collaborator

@SaoirseARM Re-run test that seem to hang

@freddan80 freddan80 merged commit dad73ca into pytorch:main Jan 17, 2025
107 checks passed
YIWENX14 pushed a commit that referenced this pull request Jan 28, 2025
@SaoirseARM @YIWENX14
Fix for multiple outputs in FVP tests (#7650)
5a71ead 
Fix for multiple outputs in corstone

- Update to ensure all output nodes are consumed.
- Update to ensure output quant scales are used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freddan80 freddan80 freddan80 approved these changes

Assignees
No one assigned
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SaoirseARM @freddan80 @facebook-github-bot