Validate tensor sizes during method load #7663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7663
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit 1075351 with merge base 1b7b10e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68180029 |
JacobSzwejbka
approved these changes
Jan 14, 2025
|
Why didnt we just make it a uint in the schema originally 🤔 |
Summary: If a tensor's `sizes` array contains a negative value, the TensorImpl ctor will panic. Validate sizes before creating the TensorImpl to treat this as a non-fatal error when loading malformed PTE files. Reviewed By: JacobSzwejbka Differential Revision: D68180029
dbort
force-pushed
the
export-D68180029
branch
from
e1ae2a4 to
1075351
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68180029 |
YIWENX14
pushed a commit
that referenced
this pull request
Jan 28, 2025
Differential Revision: D68180029 Pull Request resolved: #7663
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
If a tensor's
sizesarray contains a negative value, the TensorImpl ctor will panic.Validate sizes before creating the TensorImpl to treat this as a non-fatal error when loading malformed PTE files.
Differential Revision: D68180029