Skip to content

Additional QNN version fix #7664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Additional QNN version fix #7664

merged 1 commit into from
Jan 15, 2025

Conversation

guangy10
Copy link
Contributor

QNN version is bumped in #6811. Additional fix in android-perf

@guangy10 guangy10 requested a review from kirklandsign January 15, 2025 00:01
Copy link

pytorch-bot bot commented Jan 15, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7664

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 7 Pending

As of commit 3c9d661 with merge base 8a5f52b (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 15, 2025
Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cccclai
Copy link
Contributor

cccclai commented Jan 15, 2025

Should we consolidate to use .ci/scripts/build-qnn-sdk.sh to avoid issues like this?

@guangy10 guangy10 temporarily deployed to upload-benchmark-results January 15, 2025 00:48 — with GitHub Actions Inactive
@guangy10
Copy link
Contributor Author

Should we consolidate to use .ci/scripts/build-qnn-sdk.sh to avoid issues like this?

Yeah, there was an issue of extracting those env vars from the GA. I can look into it and follow up in a separate PR.

@guangy10 guangy10 merged commit 0b81bb6 into main Jan 15, 2025
53 of 55 checks passed
@guangy10 guangy10 deleted the fix_qnn_version branch January 15, 2025 00:55
YIWENX14 pushed a commit that referenced this pull request Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants