fix-up #7665
Merged
fix-up #7665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7665
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 8caa6d3 with merge base 8a5f52b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
jorgep31415
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring OSS and internal back in sync. See https://www.internalfb.com/diff/D67796506?dst_version_fbid=28361059690174686&transaction_fbid=1009281214354288
I think the fix-up patch was caused by the changes here:
D67821941 -> landed change
D67906023 -> reverted ^change
PR for the revert landed as #7545 into author's branch.
Pytorchbot landed it into main as #7566.
The file contents here are different, causing internal and oss to go out of sync. It looks like something weird happened with difftrain/pytorchbot here.