Skip to content

install_requirements.py: refactor: extract install_requirements() function #7704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jan 17, 2025

Conversation

swolchok
Copy link
Contributor

More preparation for separating installation of requirements from installation of ExecuTorch.

Test Plan: ./install_requirements.sh in a fresh venv succeeded and reported installing executorch

[ghstack-poisoned]
[ghstack-poisoned]
Copy link

pytorch-bot bot commented Jan 16, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7704

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 16, 2025
@swolchok swolchok added the release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. label Jan 16, 2025
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
Base automatically changed from gh/swolchok/134/head to main January 17, 2025 00:37
[ghstack-poisoned]
@swolchok swolchok merged commit 9f47380 into main Jan 17, 2025
7 checks passed
@swolchok swolchok deleted the gh/swolchok/135/head branch January 17, 2025 00:41
huydhn added a commit that referenced this pull request Jan 24, 2025
YIWENX14 pushed a commit that referenced this pull request Jan 28, 2025
…ction (#7704)

More preparation for separating installation of requirements from installation of ExecuTorch.

Test Plan: ./install_requirements.sh in a fresh venv succeeded and reported installing executorch
kedarnath03 pushed a commit to kedarnath03/executorch that referenced this pull request Jun 25, 2025
…ction

More preparation for separating installation of requirements from installation of ExecuTorch.

Test Plan: ./install_requirements.sh in a fresh venv succeeded and reported installing executorch

ghstack-source-id: aed359b
ghstack-comment-id: 2596313423
Pull Request resolved: pytorch/executorch#7704
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants