-
Notifications
You must be signed in to change notification settings - Fork 607
Add install_requirements.{sh,py} that only install requirements #7715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7715
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 7 PendingAs of commit b6da309 with merge base ee1d7c3 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
||
import install_executorch | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
np: don't you wanna do the other way around?
move the install_requirements()
function into this file instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
merging on the strength of previous green CI despite a few runs not quite having finished. |
Now that the previous PR renamed install_requirements to install_executorch, we can use those names for scripts that actually just install requirements.
…rch#7715) Now that the previous PR renamed install_requirements to install_executorch, we can use those names for scripts that actually just install requirements.
Now that the previous PR renamed install_requirements to install_executorch, we can use those names for scripts that actually just install requirements. ghstack-source-id: a2f077a ghstack-comment-id: 2597040494 Pull Request resolved: pytorch/executorch#7715
Now that the previous PR renamed install_requirements to install_executorch, we can use those names for scripts that actually just install requirements.