Skip to content

Add install_requirements.{sh,py} that only install requirements #7715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 41 commits into from
Jan 17, 2025

Conversation

swolchok
Copy link
Contributor

Now that the previous PR renamed install_requirements to install_executorch, we can use those names for scripts that actually just install requirements.

[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Jan 16, 2025

Copy link

pytorch-bot bot commented Jan 16, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7715

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 7 Pending

As of commit b6da309 with merge base ee1d7c3 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 16, 2025
swolchok added a commit that referenced this pull request Jan 16, 2025
Now that the previous PR renamed install_requirements to install_executorch, we can use those names for scripts that actually just install requirements.

ghstack-source-id: 8c1035d
ghstack-comment-id: 2597040494
Pull Request resolved: #7715
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]

import install_executorch


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

np: don't you wanna do the other way around?

move the install_requirements() function into this file instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
Base automatically changed from gh/swolchok/137/head to main January 17, 2025 20:32
[ghstack-poisoned]
@swolchok swolchok added the release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. label Jan 17, 2025
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

merging on the strength of previous green CI despite a few runs not quite having finished.

@swolchok swolchok merged commit cd0e584 into main Jan 17, 2025
47 of 48 checks passed
@swolchok swolchok deleted the gh/swolchok/138/head branch January 17, 2025 21:39
huydhn added a commit that referenced this pull request Jan 24, 2025
YIWENX14 pushed a commit that referenced this pull request Jan 28, 2025
Now that the previous PR renamed install_requirements to install_executorch, we can use those names for scripts that actually just install requirements.
zonglinpeng pushed a commit to zonglinpeng/executorch that referenced this pull request Jan 30, 2025
…rch#7715)

Now that the previous PR renamed install_requirements to install_executorch, we can use those names for scripts that actually just install requirements.
kedarnath03 pushed a commit to kedarnath03/executorch that referenced this pull request Jun 25, 2025
Now that the previous PR renamed install_requirements to install_executorch, we can use those names for scripts that actually just install requirements.

ghstack-source-id: a2f077a
ghstack-comment-id: 2597040494
Pull Request resolved: pytorch/executorch#7715
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants