Skip to content

don't touch CMAKE_BUILD_ARGS in install_executorch.py #7716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 51 commits into from
Jan 17, 2025
Merged

don't touch CMAKE_BUILD_ARGS in install_executorch.py #7716

merged 51 commits into from
Jan 17, 2025

Conversation

swolchok
Copy link
Contributor

It's not used.

swolchok added 19 commits January 16, 2025 09:30
@swolchok
Update
da1df94 
[ghstack-poisoned]
@swolchok
Update
e411a1e 
[ghstack-poisoned]
@swolchok
Update
6e9745c 
[ghstack-poisoned]
@swolchok
Update
6d65549 
[ghstack-poisoned]
@swolchok
Update
ac71f8d 
[ghstack-poisoned]
@swolchok
Update
00fd17d 
[ghstack-poisoned]
@swolchok
Update
9a1ddde 
[ghstack-poisoned]
@swolchok
Update
2063432 
[ghstack-poisoned]
@swolchok
Update
cd79afd 
[ghstack-poisoned]
@swolchok
Update
e76d22f 
[ghstack-poisoned]
@swolchok
Update
a893391 
[ghstack-poisoned]
@swolchok
Update
84b8e5f 
[ghstack-poisoned]
@swolchok
Update
fd0a5b1 
[ghstack-poisoned]
@swolchok
Update
bf753a8 
[ghstack-poisoned]
@swolchok
Update
9158d0e 
[ghstack-poisoned]
@swolchok
Update
400ec37 
[ghstack-poisoned]
@swolchok
Update
cab1ad3 
[ghstack-poisoned]
@swolchok
Update
1238f24 
[ghstack-poisoned]
@swolchok
Update
cc87ad3 
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Jan 16, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jan 16, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7716

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Pending

As of commit c788265 with merge base cd0e584 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Jan 16, 2025
Merged
Merged
Merged
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 16, 2025
This was referenced Jan 16, 2025
Merged
Merged
swolchok added a commit that referenced this pull request Jan 16, 2025
@swolchok
don't touch CMAKE_BUILD_ARGS in install_executorch.py
fb62d7d 
It's not used.

ghstack-source-id: 3eab6a4
ghstack-comment-id: 2597050943
Pull Request resolved: #7716
@swolchok
Update
4561c6b 
[ghstack-poisoned]
@swolchok
Update
c208b1f 
[ghstack-poisoned]
@swolchok
Update
f2719b2 
[ghstack-poisoned]
@swolchok
Update
a668582 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jan 17, 2025
@swolchok
don't touch CMAKE_BUILD_ARGS in install_executorch.py
4701af5 
It's not used.

ghstack-source-id: fea91e1
ghstack-comment-id: 2597050943
Pull Request resolved: #7716
@swolchok
Update
4b3f654 
[ghstack-poisoned]
@swolchok
Update
a4f50f8 
[ghstack-poisoned]
@swolchok
Update
922f051 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jan 17, 2025
@swolchok
don't touch CMAKE_BUILD_ARGS in install_executorch.py
b05d81b 
It's not used.

ghstack-source-id: ef90ff6
ghstack-comment-id: 2597050943
Pull Request resolved: #7716
@mergennachin mergennachin mentioned this pull request Jan 17, 2025
Closed
5 tasks
@swolchok
Update
86e9c74 
[ghstack-poisoned]
@swolchok
Update
87a4c2d 
[ghstack-poisoned]
@swolchok
Update
173018e 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jan 17, 2025
@swolchok
don't touch CMAKE_BUILD_ARGS in install_executorch.py
6456c3a 
It's not used.

ghstack-source-id: 9b58945
ghstack-comment-id: 2597050943
Pull Request resolved: #7716
@swolchok
Update
5ca60ad 
[ghstack-poisoned]
@swolchok
Update
296e827 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jan 17, 2025
@swolchok
don't touch CMAKE_BUILD_ARGS in install_executorch.py
3918f39 
It's not used.

ghstack-source-id: 398a9f0
ghstack-comment-id: 2597050943
Pull Request resolved: #7716
@swolchok
Update
b6da309 
[ghstack-poisoned]
@swolchok
Update
f2b1e1d 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jan 17, 2025
@swolchok
don't touch CMAKE_BUILD_ARGS in install_executorch.py
98278f5 
It's not used.

ghstack-source-id: 6177864
ghstack-comment-id: 2597050943
Pull Request resolved: #7716
Base automatically changed from gh/swolchok/138/head to main January 17, 2025 21:39
@swolchok
Update
c788265 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jan 17, 2025
@swolchok
don't touch CMAKE_BUILD_ARGS in install_executorch.py
10f480e 
It's not used.

ghstack-source-id: 6177864
ghstack-comment-id: 2597050943
Pull Request resolved: #7716
@swolchok swolchok added the release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. label Jan 17, 2025
@swolchok swolchok merged commit 57a09f4 into main Jan 17, 2025
44 of 46 checks passed
@swolchok swolchok deleted the gh/swolchok/139/head branch January 17, 2025 22:48
huydhn added a commit that referenced this pull request Jan 24, 2025
@huydhn
Revert "don't touch CMAKE_BUILD_ARGS in install_executorch.py (#7716)"
565dc28 
This reverts commit 57a09f4.
YIWENX14 pushed a commit that referenced this pull request Jan 28, 2025
@swolchok @YIWENX14
don't touch CMAKE_BUILD_ARGS in install_executorch.py (#7716)
3055a5c 
It's not used.
zonglinpeng pushed a commit to zonglinpeng/executorch that referenced this pull request Jan 30, 2025
@swolchok
don't touch CMAKE_BUILD_ARGS in install_executorch.py (pytorch#7716)
d268ad5 
It's not used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mergennachin mergennachin mergennachin approved these changes

@mcr229 mcr229 Awaiting requested review from mcr229

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swolchok @mergennachin @facebook-github-bot