Fix test to be robust against fp numerics #7796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7796
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 4 PendingAs of commit 26deda8 with merge base 948fba6 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
ezyang
approved these changes
Jan 21, 2025
|
https://github.com/pytorch/pytorch/actions/runs/12890471648/job/35941113858 My guess is that it is for even length case. p50 means taking the average of two middle elements, which may cause numerical differences... For odd length cases, it should be exact though. |
YIWENX14
pushed a commit
that referenced
this pull request
Jan 28, 2025
zonglinpeng
pushed a commit
to zonglinpeng/executorch
that referenced
this pull request
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
https://github.com/pytorch/pytorch/actions/runs/12890471648/job/35941113858