Skip to content

Fix install not finding zstd #7838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Fix install not finding zstd #7838

merged 1 commit into from
Jan 22, 2025

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Jan 22, 2025

Installation apparently couldn't resolve buck from a clean checkout. (I'm not sure how it managed to work for anybody who hadn't installed prior to the breakage, actually.)

Fixes #7711.

Test Plan: ./install_executorch.sh --clean
rm -rf buck2-bin buck-out
./install_executorch.sh --pybind xnnpack

Installation apparently couldn't find buck from a clean checkout. (I'm not sure how it managed to work for anybody, actually.)

Fixes #7711.

Test Plan: ./install_executorch.sh --clean
rm -rf buck2-bin buck-out
./install_executorch.sh --pybind xnnpack
@swolchok swolchok requested a review from dbort January 22, 2025 18:41
Copy link

pytorch-bot bot commented Jan 22, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7838

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit f6367e2 with merge base 4bc2029 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@swolchok swolchok requested review from mergennachin and removed request for dbort January 22, 2025 18:41
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 22, 2025
@swolchok swolchok requested review from shoumikhin and dbort January 22, 2025 18:41
@swolchok swolchok changed the title Fix install Fix install not finding zstd Jan 22, 2025
@swolchok swolchok added the release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. label Jan 22, 2025
@swolchok swolchok merged commit 74aace6 into main Jan 22, 2025
45 of 47 checks passed
@swolchok swolchok deleted the build-isolation branch January 22, 2025 20:59
huydhn added a commit that referenced this pull request Jan 24, 2025
YIWENX14 pushed a commit that referenced this pull request Jan 28, 2025
Fix install

Installation apparently couldn't find buck from a clean checkout. (I'm not sure how it managed to work for anybody, actually.)

Fixes #7711.

Test Plan: ./install_executorch.sh --clean
rm -rf buck2-bin buck-out
./install_executorch.sh --pybind xnnpack
zonglinpeng pushed a commit to zonglinpeng/executorch that referenced this pull request Jan 30, 2025
Fix install

Installation apparently couldn't find buck from a clean checkout. (I'm not sure how it managed to work for anybody, actually.)

Fixes pytorch#7711.

Test Plan: ./install_executorch.sh --clean
rm -rf buck2-bin buck-out
./install_executorch.sh --pybind xnnpack
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing dependency for cmake build in documentation.
3 participants