Mark call as deprecated #7968
Merged
Mark call as deprecated #7968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7968
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 07e7250 with merge base 5ed191a ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68726718 |
Summary: call is deprecated since it cant handle mutation. This is a no op for people using the default memory planning stuff today, but want to call out louder to people implementing their own not to do call. Reviewed By: hsharma35 Differential Revision: D68726718
JacobSzwejbka
force-pushed
the
export-D68726718
branch
from
4d8663a to
07e7250
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68726718 |
JacobSzwejbka
added
the
release notes: api
tarun292
approved these changes
Jan 27, 2025
YIWENX14
pushed a commit
that referenced
this pull request
Jan 28, 2025
Differential Revision: D68726718 Pull Request resolved: #7968
zonglinpeng
pushed a commit
to zonglinpeng/executorch
that referenced
this pull request
Jan 30, 2025
Differential Revision: D68726718 Pull Request resolved: pytorch#7968
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: call is deprecated since it cant handle mutation. This is a no op for people using the default memory planning stuff today, but want to call out louder to people implementing their own not to do call.
Differential Revision: D68726718