Skip to content

don't test Half/BFloat16 for cdist_forward in ATen mode #7980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2025
Merged

don't test Half/BFloat16 for cdist_forward in ATen mode #7980

merged 1 commit into from
Jan 27, 2025

Conversation

swolchok
Copy link
Contributor

Unbreaks internal tests.

@swolchok
Update
93b6e80 
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Jan 27, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jan 27, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7980

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 3 Pending, 1 Unrelated Failure

As of commit 93b6e80 with merge base ea9058e (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 27, 2025
swolchok added a commit that referenced this pull request Jan 27, 2025
@swolchok
don't test Half/BFloat16 for cdist_forward in ATen mode
232fe44 
Unbreaks internal tests.

ghstack-source-id: 7883125
ghstack-comment-id: 2617043708
Pull Request resolved: #7980
@swolchok swolchok added release notes: ops & kernels Changes to the opset and any new / changed kernel implementations topic: not user facing and removed release notes: ops & kernels Changes to the opset and any new / changed kernel implementations labels Jan 27, 2025
@swolchok swolchok merged commit da0d85d into main Jan 27, 2025
44 of 48 checks passed
@swolchok swolchok deleted the gh/swolchok/208/head branch January 27, 2025 23:28
@swolchok
Copy link
Contributor Author

verified unittest / linux failure was the pre-existing one before land

YIWENX14 pushed a commit that referenced this pull request Jan 28, 2025
@swolchok @YIWENX14
don't test Half/BFloat16 for cdist_forward in ATen mode (#7980)
501550a 
Unbreaks internal tests.
zonglinpeng pushed a commit to zonglinpeng/executorch that referenced this pull request Jan 30, 2025
@swolchok
don't test Half/BFloat16 for cdist_forward in ATen mode (pytorch#7980)
75dada9 
Unbreaks internal tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GregoryComer GregoryComer GregoryComer approved these changes

@manuelcandales manuelcandales Awaiting requested review from manuelcandales manuelcandales is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swolchok @GregoryComer @facebook-github-bot