-
Notifications
You must be signed in to change notification settings - Fork 608
Enable Training Pybindings in OSS #8073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8073
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 6 PendingAs of commit 4677709 with merge base 6b58e2e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
If you're adding a new python extension, you'll need to let setup.py know about it so it can include it in the wheel. You'll at least need an entry at Line 671 in 0733973
Line 572 in 0733973
|
Once you add it to the wheel, you can test it by running |
CMakeLists.txt
Outdated
@@ -240,6 +240,17 @@ cmake_dependent_option( | |||
"NOT EXECUTORCH_BUILD_ARM_BAREMETAL" OFF | |||
) | |||
|
|||
if(EXECUTORCH_BUILD_PYBIND) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved these here to better match the pattern in the rest of the file and also it makes the shared dependencies between training and pybind a little easier to handle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This weirdly broke apple builds so undid
…executorch into Training_pybindings asdf
@JacobSzwejbka has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@JacobSzwejbka has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Enable the pybindings for the training lib in oss
Test plan
Open up a python terminal and try importing and using the optimizer from the bindings. (Also double checked that I didnt break the normal core pybindings)
build locally with
./install_executorch.sh --pybind training