Skip to content

Fix flaky rand() tests. #8340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Conversation

shoumikhin
Copy link
Contributor

Summary: Adjusts the upper bound to prevent rounding to 1.0 when converting to lower-precision types.

Differential Revision: D69402222

Copy link

pytorch-bot bot commented Feb 10, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8340

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 5 Pending

As of commit f909ebe with merge base 57891b7 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 10, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69402222

@shoumikhin
Copy link
Contributor Author

@pytorchbot label "topic: not user facing"

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69402222

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69402222

Summary:

Adjusts the upper bound to prevent rounding to 1.0 when converting to lower-precision types.

Reviewed By: kirklandsign

Differential Revision: D69402222
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69402222

@shoumikhin shoumikhin merged commit 16c4111 into pytorch:main Feb 10, 2025
45 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants