Update shim to unbreak OSS tests buck build #8362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8362
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 3 PendingAs of commit 4fa689d with merge base 5dd2ed3 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
swolchok
added a commit
that referenced
this pull request
Feb 11, 2025
Porting facebook/buck2-shims-meta@fe8b492 as a short-term measure until I figure out how to get us synced with that repo. Test Plan: buck2 build //runtime/test/... no longer fails with missing shim//:test error ghstack-source-id: 3beacda ghstack-comment-id: 2649766301 Pull Request resolved: #8362
kimishpatel
reviewed
Feb 12, 2025
| @@ -74,3 +75,8 @@ execution_platform( | |||
| use_windows_path_separators = host_info().os.is_windows, | |||
| visibility = ["PUBLIC"], | |||
| ) | |||
|
|
|||
| noop_test_toolchain( | |||
There was a problem hiding this comment.
Can you leave a comment here similar to what you said in summary so that in case you dont pick up the followup action item, someone else can
kimishpatel
approved these changes
Feb 12, 2025
|
noting that CI is all green and my next update will just add a comment, so I may land without waiting for 100% green |
swolchok
added a commit
that referenced
this pull request
Feb 12, 2025
Porting facebook/buck2-shims-meta@fe8b492 as a short-term measure until I figure out how to get us synced with that repo. Test Plan: buck2 build //runtime/test/... no longer fails with missing shim//:test error ghstack-source-id: 28c7b9b ghstack-comment-id: 2649766301 Pull Request resolved: #8362
|
unrelated lintrunner error, known flake in unittest-mac, landing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting facebook/buck2-shims-meta@fe8b492 as a short-term measure until I figure out how to get us synced with that repo.
Test Plan: buck2 build //runtime/test/... no longer fails with missing shim//:test error