Add smart mask style KVCache and mask #8463
Merged
+154
−91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8463
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 7b10da4 with merge base 2fff01a ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D69595959 |
sxu
requested review from
kimishpatel,
iseeyuan and
billmguo
and removed request for
iseeyuan and
kimishpatel
Summary: Python reference for cache and mask updates. Support smart mask in addition to shift pointers. Reviewed By: billmguo Differential Revision: D69595959
sxu
force-pushed
the
export-D69595959
branch
from
2a00c5a to
7b10da4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69595959 |
iseeyuan
approved these changes
Feb 20, 2025
billmguo
approved these changes
Feb 20, 2025
|
what is smart mask? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Python reference for cache and mask updates. Support smart mask (new from QC) in addition to shift pointers.
Differential Revision: D69595959