Skip to content

Extract unittest scripts and add Buck mode #8493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 19, 2025
Merged

Extract unittest scripts and add Buck mode #8493

merged 4 commits into from
Feb 19, 2025

Conversation

swolchok
Copy link
Contributor

Fixes #8419

@swolchok
Update
ab96fd7 
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Feb 14, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Feb 14, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8493

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 053b6ce with merge base b5c0c61 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 14, 2025
swolchok added a commit that referenced this pull request Feb 14, 2025
@swolchok
Extract unittest scripts and add Buck mode
4ffa80c 
Fixes #8419

ghstack-source-id: f62e666
ghstack-comment-id: 2658182008
Pull Request resolved: #8493
@swolchok swolchok added the release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. label Feb 14, 2025
mergennachin
mergennachin reviewed Feb 14, 2025
View reviewed changes
.ci/scripts/unittest-linux.sh Outdated
if [[ "$BUILD_TOOL" == "cmake" ]]; then
.ci/scripts/unittest-linux-cmake.sh
elif [[ "$BUILD_TOOL" == "buck2" ]]; then
.ci/scripts/unittest-linux-buck2.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file doesn't exist

@swolchok
Update
be78434 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Feb 18, 2025
@swolchok
Extract unittest scripts and add Buck mode
f76b1be 
Fixes #8419

ghstack-source-id: 36e19d1
ghstack-comment-id: 2658182008
Pull Request resolved: #8493
@swolchok
Update
0dce3a8 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Feb 18, 2025
@swolchok
Extract unittest scripts and add Buck mode
15962df 
Fixes #8419

ghstack-source-id: 065f8c3
ghstack-comment-id: 2658182008
Pull Request resolved: #8493
@swolchok
Update
053b6ce 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Feb 18, 2025
@swolchok
Extract unittest scripts and add Buck mode
2c4adcd 
Fixes #8419

ghstack-source-id: 483f2bf
ghstack-comment-id: 2658182008
Pull Request resolved: #8493
@swolchok swolchok mentioned this pull request Feb 18, 2025
Merged
@swolchok
Copy link
Contributor Author

CI looks good, just waiting for review

mergennachin
mergennachin reviewed Feb 19, 2025
View reviewed changes
.ci/scripts/unittest-macos.sh
.ci/scripts/setup-macos.sh cmake

# Install llama3_2_vision dependencies.
PYTHON_EXECUTABLE=python ./examples/models/llama3_2_vision/install_requirements.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python ${CONDA_RUN}...?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the conda run is right there on line 29, and the code comes directly from _unittest.yml

mergennachin
mergennachin approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@mergennachin mergennachin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unittest / macos / macos-job (pull_request) is still failing. looks like you need to run the examples/install_requirements.sh within the conda environment?

@swolchok
Copy link
Contributor Author

swolchok commented Feb 19, 2025 •
edited
Loading

unittest / macos / macos-job (pull_request) is still failing

this job has been broken for at least the past day. If you look at the logs, you can see we are running tests, it's just that the tests are failing

@swolchok swolchok merged commit e2485c9 into main Feb 19, 2025
76 of 78 checks passed
@swolchok swolchok deleted the gh/swolchok/265/head branch February 19, 2025 17:31
kedarnath03 pushed a commit to kedarnath03/executorch that referenced this pull request Jun 25, 2025
@swolchok
Extract unittest scripts and add Buck mode
7c2b8f2 
Fixes #8419

ghstack-source-id: 483f2bf
ghstack-comment-id: 2658182008
Pull Request resolved: pytorch/executorch#8493
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mergennachin mergennachin mergennachin approved these changes

@dbort dbort Awaiting requested review from dbort

@kirklandsign kirklandsign Awaiting requested review from kirklandsign

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

we should have a CI job that requires that the tree is buildable with buck
3 participants
@swolchok @mergennachin @facebook-github-bot