Skip to content

Update .ptd serialization target visibility to include clients #8582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

georgehong
Copy link
Contributor

Summary: Make .ptd saving utilities visible outside of targets within executorch.

Reviewed By: jackzhxng

Differential Revision: D69871232

Copy link

pytorch-bot bot commented Feb 19, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8582

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 25514aa with merge base 3e188fe (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 19, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69871232

@georgehong
Copy link
Contributor Author

@pytorchbot label "topic: not user facing"

…ch#8582)

Summary:

Make .ptd saving utilities visible outside of targets within *executorch*.

Reviewed By: jackzhxng

Differential Revision: D69871232
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69871232

@georgehong georgehong merged commit 139be81 into pytorch:main Feb 20, 2025
48 of 50 checks passed
@georgehong georgehong deleted the export-D69871232 branch February 20, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants