Skip to content

irangeify most of runtime/core/exec_aten #8612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 4, 2025
Merged

irangeify most of runtime/core/exec_aten #8612

merged 10 commits into from
Jun 4, 2025

Conversation

swolchok
Copy link
Contributor

Had to skip scalar_type_util.h because it needs the constexpr patch to land in PyTorch (and for us to update our pin to pick it up).

@swolchok
Update
accd815 
[ghstack-poisoned]
@swolchok
Update
c2644a4 
[ghstack-poisoned]
@swolchok
Update
d0bc16e 
[ghstack-poisoned]
@swolchok
Update
5b2dec7 
[ghstack-poisoned]
@swolchok
Update
d7adc34 
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Feb 21, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Feb 21, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8612

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure

As of commit 8db6054 with merge base 450d1f9 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 21, 2025
This was referenced Feb 21, 2025
Merged
Merged
swolchok added a commit that referenced this pull request Feb 21, 2025
@swolchok
irangeify most of runtime/core/exec_aten
637beb4 
Had to skip scalar_type_util.h because it needs the constexpr patch to land in PyTorch (and for us to update our pin to pick it up).

ghstack-source-id: ba94b4e
ghstack-comment-id: 2673136511
Pull Request resolved: #8612
@swolchok
Update
609944a 
[ghstack-poisoned]
@swolchok
Update
52bfd0a 
[ghstack-poisoned]
@swolchok
Update
760618a 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Feb 21, 2025
@swolchok
irangeify most of runtime/core/exec_aten
2039058 
Had to skip scalar_type_util.h because it needs the constexpr patch to land in PyTorch (and for us to update our pin to pick it up).

ghstack-source-id: b1541dd
ghstack-comment-id: 2673136511
Pull Request resolved: #8612
Base automatically changed from gh/swolchok/277/head to main February 25, 2025 00:00
@swolchok
Update
b4ae461 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jun 3, 2025
@swolchok
irangeify most of runtime/core/exec_aten
a98b270 
Had to skip scalar_type_util.h because it needs the constexpr patch to land in PyTorch (and for us to update our pin to pick it up).

ghstack-source-id: ec1c8e6
ghstack-comment-id: 2673136511
Pull Request resolved: #8612
@swolchok swolchok added the release notes: none Do not include this in the release notes label Jun 3, 2025
@swolchok
Update
8db6054 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jun 3, 2025
@swolchok
irangeify most of runtime/core/exec_aten
6a890b7 
Had to skip scalar_type_util.h because it needs the constexpr patch to land in PyTorch (and for us to update our pin to pick it up).

ghstack-source-id: 6390db6
ghstack-comment-id: 2673136511
Pull Request resolved: #8612
@swolchok
Copy link
Contributor Author

swolchok commented Jun 4, 2025

android emulator is known flaky, landing

@swolchok swolchok merged commit b5a6362 into main Jun 4, 2025
95 of 96 checks passed
@swolchok swolchok deleted the gh/swolchok/279/head branch June 4, 2025 02:03
swolchok added a commit that referenced this pull request Jun 4, 2025
@swolchok
Fix -Wformat issues from #8612
6bfad8b 
Built locally with -Wformat -Werror=format on a recent version of clang. (Apparently, clang12 which we use on CI is not new enough?)


ghstack-source-id: d676877
ghstack-comment-id: 2940815253
Pull-Request-resolved: #11360
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digantdesai digantdesai digantdesai approved these changes

@dbort dbort Awaiting requested review from dbort

@JacobSzwejbka JacobSzwejbka Awaiting requested review from JacobSzwejbka JacobSzwejbka is a code owner

@lucylq lucylq Awaiting requested review from lucylq lucylq is a code owner

@cccclai cccclai Awaiting requested review from cccclai

@mcr229 mcr229 Awaiting requested review from mcr229

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swolchok @digantdesai @facebook-github-bot