Skip to content

Fix pyre error for logits #8687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

iseeyuan
Copy link
Contributor

Summary: Fix the pyre error when logits is not initialized

Reviewed By: swolchok

Differential Revision: D70183946

Copy link

pytorch-bot bot commented Feb 25, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8687

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 25cec5d with merge base fcb40f1 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 25, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70183946

@jackzhxng jackzhxng added the release notes: examples Changes to any of our example LLMs integrations, such as Llama3 and Llava label Feb 25, 2025
Copy link
Contributor

@jackzhxng jackzhxng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trusting @swolchok's internal review

@iseeyuan
Copy link
Contributor Author

@pytorchbot label "topic: not user facing"

@jackzhxng jackzhxng removed the release notes: examples Changes to any of our example LLMs integrations, such as Llama3 and Llava label Feb 25, 2025
Summary:
Pull Request resolved: pytorch#8687

Fix the pyre error when logits is not initialized

Reviewed By: swolchok, jackzhxng

Differential Revision: D70183946
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70183946

@facebook-github-bot facebook-github-bot merged commit 93838e8 into pytorch:main Feb 25, 2025
50 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants