Skip to content

Revert #8501 and #8624 #8716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 26, 2025
Merged

Revert #8501 and #8624 #8716

merged 2 commits into from
Feb 26, 2025

Conversation

swolchok
Copy link
Contributor

#8624 caused concerning test failure internally -- out of bounds array access

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Feb 26, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8716

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 26, 2025
@swolchok swolchok merged commit f9dc6ef into main Feb 26, 2025
44 of 46 checks passed
@swolchok swolchok deleted the reverts branch February 26, 2025 02:10
iseeyuan pushed a commit that referenced this pull request Mar 14, 2025
@swolchok
Revert #8501 and #8624 (#8716)
5f32355 
* Revert "Switch to new ao quant api for 8da4w (#8501)"

This reverts commit f3fc096.

* Revert "Use to_edge_lower_and_transform for XNNPack (#8624)"

This reverts commit b5344c1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackzhxng jackzhxng jackzhxng approved these changes

@iseeyuan iseeyuan Awaiting requested review from iseeyuan

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

@lucylq lucylq Awaiting requested review from lucylq lucylq is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swolchok @jackzhxng @facebook-github-bot