Skip to content

Make pass_utils pyre-strict #9092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2025
Merged

Make pass_utils pyre-strict #9092

merged 1 commit into from
Mar 12, 2025

Conversation

mcremon-meta
Copy link
Contributor

Summary: As titled. Requires the removal of some unneeded Type[] markers in the OSS aot file too.

Differential Revision: D70903186

@mcremon-meta mcremon-meta requested a review from tarun292 as a code owner March 10, 2025 17:42
Copy link

pytorch-bot bot commented Mar 10, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9092

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 78d12f8 with merge base 9dcee22 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 10, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70903186

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70903186

facebook-github-bot pushed a commit that referenced this pull request Mar 11, 2025
Summary:

As titled. Requires some changes on the OSS side too.

Reviewed By: zonglinpeng

Differential Revision: D70903186
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70903186

Summary:

As titled. Requires some changes on the OSS side too.

Reviewed By: zonglinpeng

Differential Revision: D70903186
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70903186

@facebook-github-bot facebook-github-bot merged commit 8f27305 into main Mar 12, 2025
50 of 52 checks passed
@facebook-github-bot facebook-github-bot deleted the export-D70903186 branch March 12, 2025 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants