removed unnecessary datasink checks #9211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9211
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit ef57c18 with merge base 7901539 ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D71081481 |
Gasoonjia
added a commit
to Gasoonjia/executorch-1
that referenced
this pull request
Mar 12, 2025
Summary: This diff removes unnecessary datasink checks in etdump to avoid false alarm when user dumping debug data. Differential Revision: D71081481
Gasoonjia
force-pushed
the
export-D71081481
branch
from
707e757 to
1db2f33
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71081481 |
Gasoonjia
added a commit
to Gasoonjia/executorch-1
that referenced
this pull request
Mar 13, 2025
Summary: This diff removes unnecessary datasink checks in etdump to avoid false alarm when user dumping debug data. Reviewed By: Jack-Khuu Differential Revision: D71081481
Gasoonjia
force-pushed
the
export-D71081481
branch
from
1db2f33 to
79e0f60
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71081481 |
|
@pytorchbot label "topic: not user facing" |
Jack-Khuu
approved these changes
Mar 13, 2025
Gasoonjia
force-pushed
the
export-D71081481
branch
from
79e0f60 to
1286ca9
Compare
Gasoonjia
added a commit
to Gasoonjia/executorch-1
that referenced
this pull request
Mar 13, 2025
Summary: This diff removes unnecessary datasink checks in etdump to avoid false alarm when user dumping debug data. Reviewed By: Jack-Khuu Differential Revision: D71081481
Gasoonjia
added a commit
to Gasoonjia/executorch-1
that referenced
this pull request
Mar 13, 2025
Summary: This diff removes unnecessary datasink checks in etdump to avoid false alarm when user dumping debug data. Reviewed By: Jack-Khuu Differential Revision: D71081481
Gasoonjia
force-pushed
the
export-D71081481
branch
from
1286ca9 to
989629e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71081481 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D71081481 |
Gasoonjia
added a commit
to Gasoonjia/executorch-1
that referenced
this pull request
Mar 13, 2025
Summary: Pull Request resolved: pytorch#9211 This diff removes unnecessary datasink checks in etdump to avoid false alarm when user dumping debug data. Reviewed By: Jack-Khuu Differential Revision: D71081481
Gasoonjia
force-pushed
the
export-D71081481
branch
from
989629e to
a8048e5
Compare
Summary: This diff removes unnecessary datasink checks in etdump to avoid false alarm when user dumping debug data. Reviewed By: Jack-Khuu Differential Revision: D71081481
Gasoonjia
force-pushed
the
export-D71081481
branch
from
a8048e5 to
ef57c18
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71081481 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D71081481