Fix optional graph_signature access in memory planning #9325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9325
Note: Links to docs will display an error until the docs builds have been completed. ⏳ 3 Pending, 1 Unrelated FailureAs of commit 4592489 with merge base 8fbdb17 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
jathu
force-pushed
the
jathu/fix-broken-memory-map
branch
from
5e86901 to
5a072a8
Compare
jathu
requested review from
JacobSzwejbka,
tarun292 and
larryliu0820
as code owners
jathu
added
module: exir
swolchok
approved these changes
Mar 17, 2025
jathu
force-pushed
the
jathu/fix-broken-memory-map
branch
from
5a072a8 to
4592489
Compare
DannyYuyang-quic
pushed a commit
to CodeLinaro/executorch
that referenced
this pull request
Apr 2, 2025
### Summary CI is broken due to pytorch#8031. `graph_signature` is optional, and is None. ### Test plan CI cc @JacobSzwejbka @angelayi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
CI is broken due to #8031.
graph_signatureis optional, and is None.Test plan
CI
cc @JacobSzwejbka @angelayi