Handle value and tensor errors as NSErrors keeping the underlying error codes #9503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9503
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 7 Pending, 1 Unrelated FailureAs of commit e3d3933 with merge base 9a6a393 ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D71592464 |
…or codes (pytorch#9503) Summary: Pull Request resolved: pytorch#9503 Change the value and tensor errors to NSErrors and to throw with ET error codes. Reviewed By: shoumikhin Differential Revision: D71592464
|
This pull request was exported from Phabricator. Differential Revision: D71592464 |
bsoyluoglu
force-pushed
the
export-D71592464
branch
from
b88a793 to
e3d3933
Compare
shoumikhin
approved these changes
Mar 21, 2025
shoumikhin
added
module: ios
DannyYuyang-quic
pushed a commit
to CodeLinaro/executorch
that referenced
this pull request
Apr 2, 2025
…or codes Differential Revision: D71592464 Pull Request resolved: pytorch#9503
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Change the value and tensor errors to NSErrors and to throw with ET error codes.
Reviewed By: shoumikhin
Differential Revision: D71592464
cc @shoumikhin @cbilgin