Skip to content

Arm backend: Check memory allocation on target #9735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

zingo
Copy link
Collaborator

@zingo zingo commented Mar 28, 2025

This fix a problem with the code continue running efter a faild allocation and sync up the example to better match examples/devtools/example_runner/example_runner.cpp

Change-Id: I2aed25ab892ef9870341314fe8a04d73f2392f9a

cc @digantdesai @freddan80 @per @oscarandersson8218

@zingo zingo requested a review from digantdesai as a code owner March 28, 2025 10:59
Copy link

pytorch-bot bot commented Mar 28, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9735

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job

As of commit fb69e6f with merge base eef0010 (image):

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 28, 2025
@zingo zingo added ciflow/trunk partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing labels Mar 28, 2025
@oscarandersson8218 oscarandersson8218 self-requested a review March 31, 2025 08:16
Copy link
Collaborator

@oscarandersson8218 oscarandersson8218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This fix a problem with the code continue running efter a faild
allocation and sunc up the example to better match
examples/devtools/example_runner/example_runner.cpp

Signed-off-by: Zingo Andersen <[email protected]>
Change-Id: I2aed25ab892ef9870341314fe8a04d73f2392f9a
@zingo zingo force-pushed the Arm-backend-Check-memory-allocation-on-target branch from e090d35 to fb69e6f Compare March 31, 2025 08:20
@zingo
Copy link
Collaborator Author

zingo commented Mar 31, 2025

qnn test fail are unrelated

@zingo zingo merged commit 69cc7fa into pytorch:main Mar 31, 2025
171 of 172 checks passed
@zingo zingo deleted the Arm-backend-Check-memory-allocation-on-target branch April 4, 2025 10:02
kirklandsign pushed a commit that referenced this pull request Apr 11, 2025
This fix a problem with the code continue running efter a faild
allocation and sync up the example to better match
examples/devtools/example_runner/example_runner.cpp

Signed-off-by: Zingo Andersen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants