Skip to content

Commit e900ee1

Browse files
authored
Better libtorch definitions for test channel (#4720)
We should be testing particular version rather than latest. Test plan: ``` % python tools/scripts/generate_binary_build_matrix.py --operating-system macos --channel test --package-type libtorch|jq { "include": [ { "gpu_arch_type": "cpu", "gpu_arch_version": "", "desired_cuda": "cpu", "libtorch_variant": "shared-with-deps", "libtorch_config": "", "devtoolset": "cxx11-abi", "container_image": "pytorch/libtorch-cxx11-builder:cpu", "package_type": "libtorch", "build_name": "libtorch-cpu-shared-with-deps-cxx11-abi", "validation_runner": "macos-12", "installation": "https://download.pytorch.org/libtorch/test/cpu/libtorch-macos-2.1.1.zip", "channel": "test", "stable_version": "2.1.1" } ] } ```
1 parent b21ac01 commit e900ee1

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

tools/scripts/generate_binary_build_matrix.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -238,11 +238,8 @@ def get_libtorch_install_command(
238238
if os in [MACOS, MACOS_ARM64]:
239239
arch = "x86_64" if os == MACOS else "arm64"
240240
build_name = f"libtorch-macos-{arch}-latest.zip"
241-
if channel == RELEASE:
241+
if channel in [RELEASE, TEST]:
242242
build_name = f"libtorch-macos-{mod.CURRENT_VERSION}.zip"
243-
# Please note this is temporary, to be removed when doing branch cut for 2.2 release
244-
elif channel == TEST:
245-
build_name = "libtorch-macos-latest.zip"
246243

247244
elif os == LINUX and (channel == RELEASE or channel == TEST):
248245
build_name = (

0 commit comments

Comments
 (0)